Skip to content

Conversation

@rjrudin
Copy link
Contributor

@rjrudin rjrudin commented Oct 13, 2025

Jenkins is getting an issue resolving 4.7.0 ml-gradle, so shifting to 6.0.1 - which is fine to use here because we don't need ml-gradle for deploying any LSQT stuff.

Copilot AI review requested due to automatic review settings October 13, 2025 16:49
@github-actions
Copy link

github-actions bot commented Oct 13, 2025

Copyright Validation Results
Total: 8 | Passed: 1 | Failed: 0 | Skipped: 7 | at: 2025-10-13 18:20:25 UTC | commit: 202f9ae

⏭️ Skipped (Excluded) Files

  • .copyrightconfig
  • Jenkinsfile
  • test-complete-app/build.gradle
  • test-complete-app/gradle/wrapper/gradle-wrapper.jar
  • test-complete-app/gradle/wrapper/gradle-wrapper.properties
  • test-complete-app/gradlew
  • test-complete-app/gradlew.bat

✅ Valid Files

  • test-complete/nodejs-optic-nodes.js

✅ All files have valid copyright headers!

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a Jenkins deployment issue by updating the ml-gradle plugin version from 4.7.0 to 6.0.1 in the test-complete-app, along with updating Gradle wrapper files to support the newer plugin version.

  • Updated ml-gradle plugin from version 4.7.0 to 6.0.1 to resolve Jenkins resolution issues
  • Upgraded Gradle wrapper from version 8.4 to 8.14.3 for compatibility
  • Added documentation comment explaining the purpose of the build.gradle file

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
test-complete-app/build.gradle Updated ml-gradle plugin version and added explanatory comment
test-complete-app/gradle/wrapper/gradle-wrapper.properties Upgraded Gradle distribution version and added timeout/validation settings
test-complete-app/gradlew Updated Gradle wrapper script with modern POSIX-compliant implementation
test-complete-app/gradlew.bat Updated Windows Gradle wrapper script with improved error handling and modern syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rjrudin rjrudin force-pushed the feature/gradle-fix branch from a8b0850 to b996f06 Compare October 13, 2025 16:56
Jenkins is getting an issue resolving 4.7.0 ml-gradle, so shifting to 6.0.1 - which is fine to use here because we don't need ml-gradle for deploying any LSQT stuff.
@rjrudin rjrudin force-pushed the feature/gradle-fix branch from b996f06 to 202f9ae Compare October 13, 2025 18:20
@rjrudin rjrudin merged commit 0c36e94 into develop Oct 13, 2025
2 of 3 checks passed
@rjrudin rjrudin deleted the feature/gradle-fix branch October 13, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants